Added ordering_field to the response in GetTableRowsUseCase#1503
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds the ordering_field property from personal table settings to the response objects in multiple table use cases. The change ensures that the client receives information about which field is used for ordering results in user-specific table settings.
Changes:
- Added
ordering_fieldto theTableSettingsInRowsDSdata structure - Updated four table use cases to include
ordering_fieldin theirtable_settingsresponse object - Applied consistent code formatting (spaces to tabs) across three use case files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
backend/src/entities/table/application/data-structures/found-table-rows.ds.ts |
Added ordering_field property to TableSettingsInRowsDS class with API documentation |
backend/src/entities/table/use-cases/get-table-rows.use.case.ts |
Added ordering_field to the table_settings object in the response |
backend/src/entities/table/use-cases/update-row-in-table.use.case.ts |
Added ordering_field to the table_settings response and applied code formatting changes |
backend/src/entities/table/use-cases/get-row-by-primary-key.use.case.ts |
Added ordering_field to the table_settings response and applied code formatting changes |
backend/src/entities/table/use-cases/add-row-in-table.use.case.ts |
Added ordering_field to the table_settings response and applied code formatting changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.